Blizzara commented on issue #13318: URL: https://github.com/apache/datafusion/issues/13318#issuecomment-2487850444
I read through the proposal again now and I'm fully in favor of it. Providing the ability to handle UDTs, UDFs, and the extension types would be useful, but also having the ability to override specific parts of the consumer is something I'd have liked to have multiple times, to e.g. test out things or to hack something together quickly before contributing upstream. I think the idea of a trait with default impls makes sense. There'll probably also be helper functions which don't need to be part of the trait, but we could make those public as well so that people can re-use as much code as possible while overriding just the behavior they need. Re API breaks, what you suggest makes a lot of sense to me - we can keep the "current API" working and quite stable while the new one is developing. I think that should be fine; whenever I upgrade DF there's anyways some compile-time breaks to take care of, and I think anyone using customized Substrait handling can be expected to deal with those as well 😄 Obviously will be nice to one day have something stable, but it doesn't need to be the first goal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
