alamb opened a new pull request, #13507: URL: https://github.com/apache/datafusion/pull/13507
Builds on https://github.com/apache/datafusion/pull/13290 from @joseph-isaacs ## Which issue does this PR close? Follow on to - https://github.com/apache/datafusion/pull/13290 ## Rationale for this change If we are going to change the signature of `invoke` I would to make it possible in the future to reuse allocations -- at the moment the API requires creating new arrays even when the input array is not used because the functions get the input as `&[ColumnarValues]` meaning they don't own them (the caller retains a reference) ## What changes are included in this PR? Change ScalarFunctionArgs to pass by value 1, ## Are these changes tested? <!-- We typically require tests for all PRs in order to: 1. Prevent the code from being accidentally broken by subsequent changes 2. Serve as another way to document the expected behavior of the code If tests are not included in your PR, please explain why (for example, are they covered by existing tests)? --> ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
