gruuya commented on issue #13481: URL: https://github.com/apache/datafusion/issues/13481#issuecomment-2489444909
Indeed digging a bit more suggests that non-matching nullability is sort of ok, as it can be explained away like this - `true` for the input nullability, as it falls back to the default value in `ScalarUDFImpl::is_nullable` (which `MakeArray` doesn't override) https://github.com/apache/datafusion/blob/5ee524ec70b1f10a078caca62954ce37b2dc3cc6/datafusion/expr/src/udf.rs#L476-L478 - `false` for the output nullability, as it reduces to checking whether the single list scalar element is null or not https://github.com/apache/datafusion/blob/5ee524ec70b1f10a078caca62954ce37b2dc3cc6/datafusion/common/src/scalar/mod.rs#L1559 Incidentally the first one matches the actual nullability in the schema, whereas the second doesn't/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
