andygrove commented on code in PR #1108: URL: https://github.com/apache/datafusion-comet/pull/1108#discussion_r1852087581
########## native/core/src/execution/datafusion/shuffle_writer.rs: ########## @@ -139,6 +140,14 @@ impl ExecutionPlan for ShuffleWriterExec { ) -> Result<SendableRecordBatchStream> { let input = self.input.execute(partition, Arc::clone(&context))?; let metrics = ShuffleRepartitionerMetrics::new(&self.metrics, 0); + let read_time = MetricBuilder::new(&self.metrics).subset_time("read_time", 0); + + // clone the ScanExec elapsed_compute metric + let scan_time = self Review Comment: Actually maybe you are correct. I will take another look today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org