alamb commented on code in PR #13518:
URL: https://github.com/apache/datafusion/pull/13518#discussion_r1852939766
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1671,7 +1671,7 @@ impl DataFrame {
/// # }
/// ```
pub fn with_column(self, name: &str, expr: Expr) -> Result<DataFrame> {
- let window_func_exprs = find_window_exprs(&[expr.clone()]);
+ let window_func_exprs = find_window_exprs(std::slice::from_ref(&expr));
Review Comment:
TIL https://doc.rust-lang.org/beta/std/slice/fn.from_ref.html -- very cool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
