akurmustafa commented on code in PR #13497:
URL: https://github.com/apache/datafusion/pull/13497#discussion_r1852983114
##########
datafusion/physical-expr/src/equivalence/properties.rs:
##########
@@ -1014,6 +1016,37 @@ impl EquivalenceProperties {
is_constant_recurse(&normalized_constants, &normalized_expr)
}
+ /// This function determines whether the provided expression is constant
+ /// across partitions based on the known constants.
+ ///
+ /// # Arguments
+ ///
+ /// - `expr`: A reference to a `Arc<dyn PhysicalExpr>` representing the
+ /// expression to be checked.
+ ///
+ /// # Returns
+ ///
+ /// Returns `true` if the expression is constant across all partitions
according
+ /// to equivalence group, `false` otherwise.
+ pub fn is_expr_constant_accross_partitions(
+ &self,
+ expr: &Arc<dyn PhysicalExpr>,
+ ) -> bool {
+ // As an example, assume that we know columns `a` and `b` are constant.
Review Comment:
Exactly, when constantness is correct across partitions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
