alamb commented on code in PR #1521:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1521#discussion_r1855176961
##########
src/parser/mod.rs:
##########
@@ -3532,16 +3532,11 @@ impl<'a> Parser<'a> {
// e.g. `SELECT 1, 2, FROM t`
//
https://cloud.google.com/bigquery/docs/reference/standard-sql/lexical#trailing_commas
//
https://docs.snowflake.com/en/release-notes/2024/8_11#select-supports-trailing-commas
- //
- // This pattern could be captured better with RAII type semantics, but
it's quite a bit of
- // code to add for just one case, so we'll just do it manually here.
- let old_value = self.options.trailing_commas;
- self.options.trailing_commas |=
self.dialect.supports_projection_trailing_commas();
- let ret = self.parse_comma_separated(|p| p.parse_select_item());
- self.options.trailing_commas = old_value;
+ let trailing_commas =
Review Comment:
this is a nice improvement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
