ayman-sigma commented on code in PR #1540:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1540#discussion_r1855531149
##########
tests/sqlparser_snowflake.rs:
##########
@@ -2846,3 +2846,32 @@ fn test_parse_show_columns_sql() {
snowflake().verified_stmt("SHOW COLUMNS IN TABLE abc");
snowflake().verified_stmt("SHOW COLUMNS LIKE '%xyz%' IN TABLE abc");
}
+
+#[test]
+fn test_sf_double_dot_notation() {
+ snowflake().verified_stmt("SELECT * FROM db_name..table_name");
+ snowflake().verified_stmt("SELECT * FROM x, y..z JOIN a..b AS b ON x.id =
b.id");
+}
+
+#[test]
+fn test_sf_double_dot_notation_wrong_position() {}
+
+#[test]
+fn test_parse_double_dot_notation_wrong_position() {
+ assert_eq!(
+ snowflake()
+ .parse_sql_statements("SELECT * FROM X.Y..")
+ .unwrap_err()
+ .to_string(),
+ "sql parser error: Expected: identifier, found: ."
+ );
+
+ assert_eq!(
+ // Ensure we don't parse leading token
+ snowflake()
+ .parse_sql_statements("SELECT * FROM .X.Y")
+ .unwrap_err()
+ .to_string(),
+ "sql parser error: Expected: identifier, found: ."
+ );
+}
Review Comment:
Sounds good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
