joseph-isaacs commented on code in PR #13491:
URL: https://github.com/apache/datafusion/pull/13491#discussion_r1856395735
##########
datafusion/functions/src/datetime/date_bin.rs:
##########
@@ -544,7 +548,7 @@ mod tests {
ColumnarValue::Array(timestamps),
ColumnarValue::Scalar(ScalarValue::TimestampNanosecond(Some(1), None)),
],
- batch_size,
+ 1,
Review Comment:
I had a look for all of these, but its easy to miss one, all the others that
pass an literal value take only scalars.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
