zhuliquan commented on code in PR #13531:
URL: https://github.com/apache/datafusion/pull/13531#discussion_r1856580633
##########
datafusion/core/tests/parquet/external_access_plan.rs:
##########
@@ -369,45 +379,43 @@ struct TestData {
file_size: u64,
}
-static TEST_DATA: OnceLock<TestData> = OnceLock::new();
+static _TEST_DATA: OnceLock<TestData> = OnceLock::new();
/// Return a parquet file with 2 row groups each with 5 rows
-fn get_test_data() -> &'static TestData {
- TEST_DATA.get_or_init(|| {
Review Comment:
> The reason to use the `TEST_DATA` thing was to avoid creating the same
file over and over again.
>
> Do we need to remove `TEST_DATA`?
>
> It seems like the core difference is the use of `tempfile_in` rather than
the change from static
There is no chance for delete TEST_DATA. Because there is no main test
function to lead minor test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
