Omega359 commented on PR #13527: URL: https://github.com/apache/datafusion/pull/13527#issuecomment-2498200913
> This PR seems to require `config_options` to be cloned many times now. I wonder if it is possible to avoid that 🤔. I took a brief look and it seems to be somewhat challenging as SessionState allows mutable access to the underlying SessionConfig. Yes, it's a bit annoying. I was tempted to see if I could switch to &'a ConfigOptions everywhere. There is at least one 'real' (vs Arc::clone) clone for every query, possibly more as I haven't checked. > Maybe we could change the semantics so that `SessionConfig` has a `Arc<ConfigOptions>` which was cloned when it was modified (`Arc::unwrap_or_clone()` style) 🤔 Certainly possible, I can attempt that. > I also think the const evaluator does need the actual correct ConfigOptions for correctness I was afraid of that. I was avoiding it because of the signature changes it would required just about everywhere which would cause even more headaches for those systems trying to upgrade. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
