Blizzara commented on PR #13522: URL: https://github.com/apache/datafusion/pull/13522#issuecomment-2498764862
> Whichever you like. This one was approved so we could merge and add another ticket. Or if you want to just add it in, I'll review it right away. Or if you want me to take it on, I can do that too I went ahead and added it in https://github.com/apache/datafusion/pull/13522/commits/b714d2ee41ee28efabda177b02a2e998743796f9. FYI @alamb since you had already approved. (As a followup - I wonder if we should do something similar with StringView etc? At least for the Substrait purposes, a Utf8 should probably be considered equal to Utf8View, maybe also LargeUTF8.. I guess what we'd really need is the logical type system :D) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
