alamb commented on PR #1435:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1435#issuecomment-2501256844
Amusingly when I ran with the fixed benchmarks the result is basically the
same (15% slower)
```
sqlparser-rs parsing benchmark/sqlparser::select
time: [6.5723 µs 6.5856 µs 6.6010 µs]
change: [+14.669% +15.020% +15.364%] (p = 0.00 <
0.05)
Performance has regressed.
Found 12 outliers among 100 measurements (12.00%)
11 (11.00%) high mild
1 (1.00%) high severe
sqlparser-rs parsing benchmark/sqlparser::with_select
time: [32.234 µs 32.253 µs 32.277 µs]
change: [+14.270% +14.402% +14.538%] (p = 0.00 <
0.05)
Performance has regressed.
Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) high mild
5 (5.00%) high severe
```
[fixed-flamegraph](https://github.com/user-attachments/assets/7ceae3a0-dec2-462d-9a00-0b49afd9d2bc)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
