westonpace commented on code in PR #13582:
URL: https://github.com/apache/datafusion/pull/13582#discussion_r1861018011
##########
datafusion/catalog/src/catalog.rs:
##########
@@ -102,24 +103,25 @@ use datafusion_common::Result;
///
/// [`TableProvider`]: crate::TableProvider
+#[async_trait]
pub trait CatalogProvider: Debug + Sync + Send {
/// Returns the catalog provider as [`Any`]
/// so that it can be downcast to a specific implementation.
fn as_any(&self) -> &dyn Any;
/// Retrieves the list of available schema names in this catalog.
- fn schema_names(&self) -> Vec<String>;
+ async fn schema_names(&self) -> Vec<String>;
Review Comment:
I'll try and get away with `'_`. Otherwise the memory provider will need to
clone its contents.
If callers need static they can Arc the provider, clone it, and wrap with
the call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
