goldmedal commented on code in PR #1556:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1556#discussion_r1862328322
##########
derive/src/lib.rs:
##########
@@ -256,3 +265,16 @@ fn visit_children(
Data::Union(_) => unimplemented!(),
}
}
+
+fn is_option(ty: &Type) -> bool {
+ if let Type::Path(TypePath { path: Path { segments, .. }, .. }) = ty {
+ if let Some(segment) = segments.last() {
+ if segment.ident == "Option" {
Review Comment:
Agreed, I think we won't have another struct called `Option` in this project
🤔. Or we can match the full path with `std::option::Option` or
`core::option::Option` if required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
