iffyio commented on code in PR #1567:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1567#discussion_r1862450915
##########
tests/sqlparser_postgres.rs:
##########
@@ -594,6 +594,13 @@ fn parse_alter_table_constraints_rename() {
}
}
+#[test]
+fn parse_alter_table_constraints_unique_nulls_distinct() {
+ pg_and_generic().verified_stmt("ALTER TABLE t ADD CONSTRAINT b UNIQUE
NULLS NOT DISTINCT (c)");
Review Comment:
For one of the test cases can we include an assertion on the AST, like in
[this
style](https://github.com/apache/datafusion-sqlparser-rs/blob/a54331889874ca896100b6666720d6fcb43b6965/tests/sqlparser_postgres.rs#L882-L888)?
just to sanity check where in the statement the nulls option ends up in the
tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
