comphead commented on code in PR #13584:
URL: https://github.com/apache/datafusion/pull/13584#discussion_r1862655033
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -209,6 +209,30 @@ async fn test_semi_join_1k_filtered() {
.await
}
+#[tokio::test]
+async fn test_right_semi_join_1k() {
+ JoinFuzzTestCase::new(
+ make_staggered_batches(1000),
+ make_staggered_batches(1000),
+ JoinType::RightSemi,
+ None,
+ )
+ .run_test(&[HjSmj, NljHj], true)
Review Comment:
```suggestion
.run_test(&[HjSmj, NljHj], false)
```
##########
datafusion/core/tests/fuzz_cases/join_fuzz.rs:
##########
@@ -209,6 +209,30 @@ async fn test_semi_join_1k_filtered() {
.await
}
+#[tokio::test]
+async fn test_right_semi_join_1k() {
+ JoinFuzzTestCase::new(
+ make_staggered_batches(1000),
+ make_staggered_batches(1000),
+ JoinType::RightSemi,
+ None,
+ )
+ .run_test(&[HjSmj, NljHj], true)
+ .await
+}
+
+#[tokio::test]
+async fn test_right_semi_join_1k_filtered() {
+ JoinFuzzTestCase::new(
+ make_staggered_batches(1000),
+ make_staggered_batches(1000),
+ JoinType::RightSemi,
+ Some(Box::new(col_lt_col_filter)),
+ )
+ .run_test(&[HjSmj, NljHj], true)
Review Comment:
```suggestion
.run_test(&[HjSmj, NljHj], false)
```
##########
datafusion/sqllogictest/test_files/sort_merge_join.slt:
##########
@@ -508,6 +508,124 @@ select t1.* from t1 where not exists (select 1 from t2
where t2.a = t1.a and t1.
----
+# RIGHTSEMI join tests
Review Comment:
Im not sure these tests makes a difference as RIGHT SEMI are not supported
by SQL this type of join can be called by optimizer on physical executiion
##########
datafusion/physical-plan/src/joins/sort_merge_join.rs:
##########
@@ -732,7 +727,7 @@ struct JoinedRecordBatches {
pub batches: Vec<RecordBatch>,
/// Filter match mask for each row(matched/non-matched)
pub filter_mask: BooleanBuilder,
- /// Row indices to glue together rows in `batches` and `filter_mask`
+ /// Streamed row indices to glue together rows in `batches` and
`filter_mask`
Review Comment:
```suggestion
/// Left row indices to glue together rows in `batches` and `filter_mask`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
