Dandandan commented on issue #13586:
URL: https://github.com/apache/datafusion/issues/13586#issuecomment-2507498291

   I didn't profile yet, but one potentially problematic line I found here:
   
   `concat_batches(self.input_schema(), [input_buffer, &record_batch])?`
   
   This concatenates `[input_buffer, &record_batch]`.
   
   Changing the state to a `Vec<RecordBatch>` and delaying concatenating would 
be better.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to