alamb commented on code in PR #13592:
URL: https://github.com/apache/datafusion/pull/13592#discussion_r1863528647
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -434,10 +434,22 @@ impl SimpleScalarUDF {
volatility: Volatility,
fun: ScalarFunctionImplementation,
) -> Self {
- let name = name.into();
- let signature = Signature::exact(input_types, volatility);
- Self {
+ Self::new_with_signature(
name,
+ Signature::exact(input_types, volatility),
+ return_type,
+ fun,
+ )
+ }
+
+ pub fn new_with_signature(
Review Comment:
Could we please add some more documentation (specifically calling out the
difference between this and `new`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
