alamb commented on code in PR #13605:
URL: https://github.com/apache/datafusion/pull/13605#discussion_r1864245102
##########
datafusion/sql/src/planner.rs:
##########
@@ -622,24 +622,41 @@ pub fn object_name_to_table_reference(
idents_to_table_reference(idents, enable_normalization)
}
+struct IdentTaker(Vec<Ident>);
+/// Take the next identifier from the back of idents, panic'ing if
+/// there are none left
+impl IdentTaker {
+ fn take(&mut self, enable_normalization: bool) -> String {
+ let ident = self.0.pop().expect("no more identifiers");
+ IdentNormalizer::new(enable_normalization).normalize(ident)
Review Comment:
will do in a follow on PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
