findepi commented on code in PR #13569:
URL: https://github.com/apache/datafusion/pull/13569#discussion_r1865642640
##########
datafusion/sqllogictest/src/engines/conversion.rs:
##########
@@ -101,5 +101,70 @@ pub(crate) fn decimal_to_str(value: Decimal) -> String {
}
pub(crate) fn big_decimal_to_str(value: BigDecimal) -> String {
- value.round(12).normalized().to_string()
+ // Round the value to limit the number of decimal places
+ let value = value.round(12).normalized();
+ // Format the value to a string
+ format_big_decimal(value)
Review Comment:
we could use bigdecimal `to_plain_string` (see
https://github.com/akubera/bigdecimal-rs/issues/135) -- but it's not released
yet afaict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
