andygrove commented on code in PR #1128:
URL: https://github.com/apache/datafusion-comet/pull/1128#discussion_r1866340532
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -88,6 +90,7 @@ impl ScanExec {
) -> Result<Self, CometError> {
let metrics_set = ExecutionPlanMetricsSet::default();
let baseline_metrics = BaselineMetrics::new(&metrics_set, 0);
+ let arrow_ffi_time =
MetricBuilder::new(&metrics_set).subset_time("arrow_ffi_time", 0);
Review Comment:
I see now that this isn't just FFI time. It is the cost of calling
`CometBatchIterator.next()` so includes the cost of that method getting the
next input batch as well as the FFI export cost ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
