zhuliquan commented on PR #12270: URL: https://github.com/apache/datafusion/pull/12270#issuecomment-2514990439
> Thank you for this PR @zhuliquan . Have you run any benchmarks that show this approach is noticeably faster than the existing approach? It makes sense that it would be faster as it does not re-compile the regular expression for each batch, but I think it would help to quantify this difference Hello @alamb, I have compared my approach to original `binary_expr` in many regex cases. Do I make explanations for benchmark `scalar_regex_match`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
