Omega359 commented on issue #13470:
URL: https://github.com/apache/datafusion/issues/13470#issuecomment-2515788576
> > I would also love to see a separate test-runner (maybe nightly) of the
official SQLLite SLTs (where applicable).
> > At this point DF seems to be able to pass the majority without
modification (except delete). Since they are (a) pre-vetted by sqllite and (b)
test foundational capability it would make sense to me that they are included
in datafusion
>
> I actually am part way through porting those slt's to something that df's
slt test runner can run
I've gotten many of them to run so far after removing or changing
troublesome features (create index, valuesort, etc). There are differences with
sqllite vs DataFusion wrt how sqllite handles integers vs real numbers that I'm
still working through slowly. I do see a number of failures that I believe are
real or at least point to limitations of DF. I'm hoping to have a full 'clean'
run sometime in the next week that only fails on likely valid queries.
Here is an example of something that is currently failing:
```SQL
CREATE TABLE tab0(pk INTEGER PRIMARY KEY, col0 INTEGER, col1 FLOAT, col2
TEXT, col3 INTEGER, col4 FLOAT, col5 TEXT);
INSERT INTO tab0 VALUES(0,1164,1149.64,'eyxra',1147,1174.8,'fpigl');
INSERT INTO tab0 VALUES(1,1165,1150.72,'zqxbf',1148,1175.52,'zmukh');
INSERT INTO tab0 VALUES(2,1166,1154.12,'itglg',1149,1176.1,'cfmkm');
INSERT INTO tab0 VALUES(3,1167,1156.44,'xmaca',1150,1177.85,'ggpiv');
INSERT INTO tab0 VALUES(4,1168,1157.98,'lewrx',1151,1178.59,'hjscv');
INSERT INTO tab0 VALUES(5,1169,1158.81,'enubf',1152,1180.13,'apmjh');
INSERT INTO tab0 VALUES(6,1171,1159.96,'olnov',1153,1181.89,'smeyx');
INSERT INTO tab0 VALUES(7,1172,1160.51,'yngfz',1154,1182.90,'vakuy');
INSERT INTO tab0 VALUES(8,1174,1161.72,'awjqq',1155,1183.93,'qzqaw');
SELECT pk, col0 FROM tab0 WHERE col0 IN (SELECT col3 FROM tab0 WHERE col4 >
73.18) ORDER BY 2 DESC;
SanityCheckPlan
caused by
Error during planning: Plan: ["SortPreservingMergeExec: [col0@1 DESC]", "
CoalesceBatchesExec: target_batch_size=8192", " HashJoinExec:
mode=Partitioned, join_type=RightSemi, on=[(col3@0, col0@1)]", "
CoalesceBatchesExec: target_batch_size=8192", " RepartitionExec:
partitioning=Hash([col3@0], 20), input_partitions=20", "
RepartitionExec: partitioning=RoundRobinBatch(20), input_partitions=1", "
CoalesceBatchesExec: target_batch_size=8192", " FilterExec:
CAST(col4@1 AS Float64) > 73.18, projection=[col3@0]", "
MemoryExec: partitions=1, partition_sizes=[9]", " SortExec: expr=[pk@0
DESC], preserve_partitioning=[true]", " CoalesceBatchesExec:
target_batch_size=8192", " RepartitionExec:
partitioning=Hash([col0@1], 20), input_partitions=1", " MemoryExec:
partitions=1, partition_sizes=[9]"] does not satisfy order requirements:
[col0@1 DESC]. Child-0 order: [[pk@0 DESC]]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
