parthchandra commented on code in PR #1133:
URL: https://github.com/apache/datafusion-comet/pull/1133#discussion_r1868595227
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -200,6 +217,21 @@ impl ScanExec {
let mut env = JVMClasses::get_env()?;
+ let mut timer = jvm_fetch_time.timer();
+
+ let num_rows: i32 = unsafe {
+ jni_call!(&mut env,
+ comet_batch_iterator(iter).has_next() -> i32)?
+ };
Review Comment:
I don't see a `has_next` in CometBatchIterator.java. Should this be
`comet_batch_iterator(iter).next()` ?
And if you want to change the return value you can make the change in the
Java class and also in the macro invocation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
