davisp commented on code in PR #13632:
URL: https://github.com/apache/datafusion/pull/13632#discussion_r1869780624
##########
datafusion/core/tests/dataframe/mod.rs:
##########
@@ -2050,6 +2050,139 @@ async fn
test_dataframe_placeholder_missing_param_values() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn test_dataframe_placeholder_column_parameter() -> Result<()> {
+ let ctx = SessionContext::new();
+
+ let df = ctx.read_empty().unwrap().select_exprs(&["$1"]).unwrap();
+
+ let logical_plan = df.logical_plan();
+ let formatted = logical_plan.display_indent_schema().to_string();
+ let actual: Vec<&str> = formatted.trim().lines().collect();
+ let expected = vec!["Projection: $1 [$1:Null;N]", " EmptyRelation []"];
+ assert_eq!(
+ expected, actual,
+ "\n\nexpected:\n\n{expected:#?}\nactual:\n\n{actual:#?}\n\n"
+ );
+
+ // The placeholder is not replaced with a value,
+ // so the filter data type is not know, i.e. a = $0.
Review Comment:
Addressed here: e1d66ac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
