findepi commented on code in PR #13610:
URL: https://github.com/apache/datafusion/pull/13610#discussion_r1869895643
##########
datafusion/core/tests/parquet/filter_pushdown.rs:
##########
@@ -223,7 +225,7 @@ async fn single_file() {
#[tokio::test]
async fn single_file_small_data_pages() {
- let tempdir = TempDir::new().unwrap();
+ let tempdir = TempDir::new_in(Path::new(".")).unwrap();
Review Comment:
> the temporary file will be deleted when the TempFile goes out of scope
will this work too if a test panics?
tests creating files -- or _sometimes_ creating files -- in the git repo is
something we shoulda void
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
