comphead commented on code in PR #13646: URL: https://github.com/apache/datafusion/pull/13646#discussion_r1869944075
########## docs/source/user-guide/sql/aggregate_functions.md: ########## @@ -281,11 +281,11 @@ first_value(expression [ORDER BY expression]) #### Example ```sql -> SELECT first_value(column_name ORDER BY other_column) FROM table_name; +> SELECT last_value(column_name ORDER BY other_column) FROM table_name; Review Comment: the documentation fixed now. There is an existing bug when documentation lock with the same name covers 2 or more doc functions in the same file. In this scenario documentation will pick the first available doc description which is unexpected. The migration to macros fixes the problem as it uses separate lock per function -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
