alamb commented on code in PR #13637:
URL: https://github.com/apache/datafusion/pull/13637#discussion_r1870571046
##########
datafusion/functions/src/datetime/to_local_time.rs:
##########
@@ -562,7 +562,7 @@ mod tests {
fn test_to_local_time_helper(input: ScalarValue, expected: ScalarValue) {
let res = ToLocalTimeFunc::new()
.invoke_with_args(ScalarFunctionArgs {
- args: &[ColumnarValue::Scalar(input)],
+ args: vec![ColumnarValue::Scalar(input)],
Review Comment:
In this case I actually changed `ScalarFunctionArgs` to get an owned `Vec`
Perhaps clippy suggested `[ColumnarValue::Scalar(input)],` instead of
`&vec![ColumnarValue::Scalar(input)]` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
