andygrove commented on code in PR #1139:
URL: https://github.com/apache/datafusion-comet/pull/1139#discussion_r1870676165
##########
native/spark-expr/src/utils.rs:
##########
@@ -146,6 +162,25 @@ fn timestamp_ntz_to_timestamp(
};
Ok(Arc::new(array_with_tz))
}
+ DataType::Timestamp(TimeUnit::Millisecond, None) => {
+ let array = as_primitive_array::<TimestampMillisecondType>(&array);
+ let tz: Tz = tz.parse()?;
Review Comment:
This is once per array, but I think the parsing could happen once during
planning rather than per batch/array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
