Kimahriman opened a new pull request, #13683:
URL: https://github.com/apache/datafusion/pull/13683
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #13682
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Makes null handling for `array_has` consistent across scalars and arrays,
and makes the behavior similar to other systems such as Postgres and Spark.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Updates both scalar and array handling for `array_has` to return null if any
element on the left hand side is null and the right side is not found. This is
the behavior defined by Postgres, and used by Spark as well, not sure what
other database systems use:
>If the array expression yields a null array, the result of ANY will be
null. If the left-hand expression yields null, the result of ANY is ordinarily
null (though a non-strict comparison operator could possibly yield a different
result). Also, if the right-hand array contains any null elements and no true
comparison result is obtained, the result of ANY will be null, not false
(again, assuming a strict comparison operator). This is in accordance with
SQL's normal rules for Boolean combinations of null values.
https://www.postgresql.org/docs/current/functions-comparisons.html#FUNCTIONS-COMPARISONS-ANY-SOME
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Tests are added and updated to accommodate the changes.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
Slight behavior change for both scalar and array handling of `array_has`,
which was already inconsistent.
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
