kazuyukitanimura commented on PR #1055: URL: https://github.com/apache/datafusion-comet/pull/1055#issuecomment-2532765907
Thanks @andygrove > I am not sure that the fast path reduces much cost. In the flamegraph, `currentBatch()` and `exportBatch()` blocks are significantly shortened/disappeared https://github.com/apache/datafusion-comet/pull/1055#issuecomment-2456050303 > I think it is worth exploring more but I am not sure we should merge this PR yet, I can close this for now > especially as the comet-parquet-exec work may replace some of this code. I thought this PR part does not change as we still need to send back the results to JVM for pure scan case, but I could be wrong... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
