kazuyukitanimura commented on code in PR #1156:
URL: https://github.com/apache/datafusion-comet/pull/1156#discussion_r1878839024


##########
spark/src/main/scala/org/apache/comet/parquet/ParquetFilters.scala:
##########
@@ -723,20 +723,22 @@ class ParquetFilters(
           .lift(nameToParquetField(name).fieldType)
           .map(_(nameToParquetField(name).fieldNames, value))
 
-      case sources.LessThan(name, value) if canMakeFilterOn(name, value) =>
+      case sources.LessThan(name, value) if (value != null) && 
canMakeFilterOn(name, value) =>

Review Comment:
   This is not a test code
   
   This file was copied from Spark for modification. Then there is a logic 
update for SPARK-47120
   https://github.com/apache/spark/pull/45202/files



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to