findepi commented on code in PR #13728:
URL: https://github.com/apache/datafusion/pull/13728#discussion_r1879716424
##########
.github/actions/setup-rust-runtime/action.yaml:
##########
@@ -34,5 +34,5 @@ runs:
echo "RUSTC_WRAPPER=sccache" >> $GITHUB_ENV
echo "SCCACHE_GHA_ENABLED=true" >> $GITHUB_ENV
echo "RUST_BACKTRACE=1" >> $GITHUB_ENV
- echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false" >>
$GITHUB_ENV
+ echo "RUSTFLAGS=-C debuginfo=line-tables-only -C incremental=false
-Wunused-crate-dependencies" >> $GITHUB_ENV
Review Comment:
if this is global lint, it could be defined in cargo.toml in the lint
section.
However, this is awesome for production code, but may be hard to do for
tests/benchmark code.
At least in arrow-rs, i tried to enable this globally but failed.
see https://github.com/apache/arrow-rs/pull/6804#issuecomment-2511150149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
