alamb opened a new pull request, #13731:
URL: https://github.com/apache/datafusion/pull/13731

   ## Which issue does this PR close?
   
   - Related to https://github.com/apache/datafusion/pull/13372
   
   ## Rationale for this change
   
   I want to add additional test coverage as part of helping to avoid 
regressions with @jayzhan211  et al on  
https://github.com/apache/datafusion/pull/13372
   
   It turns out that the existing date_part tests are 800+ lines in the already 
massive  expr.slt file, which makes it hard / akward to work with
   
   
   
   
   
   ## What changes are included in this PR?
   
   * This PR extracts tests for `date_part` and `extract` (which is syntactic 
sugar on `date_part`) into their own .slt files
   * Note it just moves the tests, it doesn't change or add anything (I will 
make a follow on PR to add new tests)
   
   
   
   ## Are these changes tested?
   By CI
   
   I also tested manually to verify this new file is run:
   
   ```shell
   (venv) andrewlamb@Andrews-MacBook-Pro-2:~/Software/datafusion$ cargo test 
--test sqllogictests | grep date_part
       Finished `test` profile [unoptimized + debuginfo] target(s) in 0.15s
        Running bin/sqllogictests.rs 
(target/debug/deps/sqllogictests-dee2dcb75b23ce67)
   Executed "expr/date_part.slt". Took 161.646958ms
   ```
   
   ## Are there any user-facing changes?
   No, this is an internal only change
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to