blaginin commented on code in PR #13576:
URL: https://github.com/apache/datafusion/pull/13576#discussion_r1880762215
##########
datafusion/common/src/config.rs:
##########
@@ -212,11 +219,12 @@ config_namespace! {
pub enable_ident_normalization: bool, default = true
/// When set to true, SQL parser will normalize options value (convert
value to lowercase)
- pub enable_options_value_normalization: bool, default = true
+ pub enable_options_value_normalization: bool, default = false
/// Configure the SQL dialect used by DataFusion's parser; supported
values include: Generic,
/// MySQL, PostgreSQL, Hive, SQLite, Snowflake, Redshift, MsSQL,
ClickHouse, BigQuery, and Ansi.
- pub dialect: String, default = "generic".to_string()
+ pub dialect: String, default = "generic".to_string() // no need to
lowercase because
+ // [`sqlparser::dialect_from_str`] is case-insensitive
Review Comment:
Moved to the new line. You are right, `[...]` isn't validated in comments
but I left it as is to keep consistent
<img width="945" alt="RustRover 2024-12-11 18 54 39"
src="https://github.com/user-attachments/assets/c54e436d-52aa-42dc-b3e8-4a05e2521a49";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
