milevin commented on code in PR #13741:
URL: https://github.com/apache/datafusion/pull/13741#discussion_r1881606531
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -1449,6 +1455,22 @@ fn null_coercion(lhs_type: &DataType, rhs_type:
&DataType) -> Option<DataType> {
}
}
+/// Resolves integer types to interval types for temporal arithmetic
+fn resolve_ints_to_intervals(
+ lhs: &DataType,
+ rhs: &DataType,
+) -> Option<(DataType, DataType, DataType)> {
+ use arrow::datatypes::DataType::*;
+ use arrow::datatypes::IntervalUnit::*;
+
+ match (lhs, rhs) {
+ // Handle integer + interval cases
+ (Int32 | Int64, _) => Some((Interval(DayTime), rhs.clone(),
rhs.clone())),
Review Comment:
I think so. I'll fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
