findepi commented on issue #13742: URL: https://github.com/apache/datafusion/issues/13742#issuecomment-2538750719
AFAICT, the `with_ignore_nulls: true` is currently... ignored? Given it's part of the "logical plan", it should be obeyed. It's probably part of LP because the LP is half-way between parser's AST and real plan (see also https://github.com/apache/datafusion/issues/12604 and cc @alamb). I'm OK for respecting `with_ignore_nulls` in the plan, but I would actually consider removing it completely. Simpler things are better. The same functionality is available using `AggregateFunction.filter`. What calls for keeping `with_ignore_nulls` is that aggregate functions -- in general -- skip over null inputs. SQL standard `array_agg` is one of few exceptions (and some systems like Snowflake and apparently Spark skip nulls for array_agg). Ideally this could be decided by the function itself, so could be a parameter of the `ArrayAgg` struct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
