korowa opened a new pull request, #13768:
URL: https://github.com/apache/datafusion/pull/13768
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #13574 .
(since at least this PR solves the case described in the issue)
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Currently row group pruning by Bloom filters is unaware of Dictionary typed
scalar values (the literal part of predicate) while checking for values being
contained in filter. This PR adds limited support for them -- now Bloom filter
pruning is able to handle `Dictionary(Utf8/LargeUtf8)` scalars.
The reason for not including all already supported types in
`ScalarValue::Dictionary` branch is that `ParquetExecBuilder::build` is not
able to produce pruning predicate for Dictionary(numeric/binary) datatypes, so
these queries won't normally reach bloom filter/statistics pruning.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
Part of `BloomFilterStatistics` responsible for checking scalar value
against Sbbf is moved into helper function with additional support of
Dictionary() and LargeUtf8 type.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
There are tests for both datatypes checking pruning and matching (to ensure
that there won't be any excessive pruning) cases.
## Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
