alamb commented on code in PR #13767:
URL: https://github.com/apache/datafusion/pull/13767#discussion_r1884714755
##########
datafusion/expr/src/expr.rs:
##########
@@ -313,7 +313,7 @@ pub enum Expr {
/// plan into physical plan.
Wildcard {
qualifier: Option<TableReference>,
- options: WildcardOptions,
+ options: Box<WildcardOptions>,
Review Comment:
This was needed to avoid a clippy lint about enum variants being too
different. Specifically sqlparser added some new fields to WildCardOptions
which made them substantially larger
##########
datafusion/sql/src/statement.rs:
##########
@@ -514,6 +517,35 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
return not_impl_err!("To not supported")?;
}
+ // put the statement back together temporarily to get the SQL
Review Comment:
While this formulation is more code, it does avoid serializing the entire
input string on every query, even when it is not needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
