2010YOUY01 commented on code in PR #13752:
URL: https://github.com/apache/datafusion/pull/13752#discussion_r1885081435
##########
datafusion/functions/src/unicode/initcap.rs:
##########
@@ -74,7 +76,7 @@ impl ScalarUDFImpl for InitcapFunc {
DataType::LargeUtf8 => make_scalar_function(initcap::<i64>,
vec![])(args),
DataType::Utf8View => make_scalar_function(initcap_utf8view,
vec![])(args),
other => {
- exec_err!("Unsupported data type {other:?} for function
initcap")
+ exec_err!("Unsupported data type {other:?} for function
`initcap`")
Review Comment:
```suggestion
internal_err!("Unsupported data type {other:?} for function
`initcap`")
```
Incompatible arg should be checked during planning before, thus here is
unreachable, and we can use `internal_err` to indicate a potential bug if it's
executed
##########
datafusion/sqllogictest/test_files/string/string_query.slt.part:
##########
@@ -460,7 +460,7 @@ Andrew Datafusion📊🔥
Xiangpeng Datafusion数据融合
Raphael Datafusionдатафусион
Under_Score Un Iść Core
-Percent Pan Tadeusz Ma Iść W KąT
+Percent Pan Tadeusz Ma Iść W Kąt
Review Comment:
I've checked and this result is compatible with PostgreSQL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
