korowa commented on PR #13786: URL: https://github.com/apache/datafusion/pull/13786#issuecomment-2543849481
Thank you @rluvaton Taking into account that the least/greatest implementations are almost identical (the way how these functions handle input arguments / constant folding optimization etc) and the major difference is sort options for the comparator and the method called on the comparator, perhaps it is possible to make these functions share the same parameterized implementation? I suppose, in this case it would be easier to fix/update functions behavior if required (since it'll require only one implementation modification instead of two). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
