zhuqi-lucas commented on PR #13788: URL: https://github.com/apache/datafusion/pull/13788#issuecomment-2543889166
> Thank you @zhuqi-lucas. > > Could you, please, add a test which could serve as a reproducer for this issue? Ideally if it would be an sqllogictest simpler than the example from the description, something like > > ```sql > statement ok > set datafusion.execution.parquet.pushdown_filters = true; > > # this one is also required to make DF skip second file due to "sufficient" amount of rows > statement ok > set datafusion.execution.collect_statistics = true; > > statement ok > CREATE EXTERNAL TABLE test_filter_with_limit > ( > part_key INT, > value INT, > ) > STORED AS PARQUET > LOCATION 'test_files/scratch/parquet/test_filter_with_limit/' > PARTITIONED BY (part_key); > > # There will be 2 records filtered from the table to check that `limit 1` actually applied > statement ok > insert into test_filter_with_limit (part_key, value) values (1, 0), (1, 1), (1, 100), (2, 0), (2, 2), (2, 2), (2, 100); > > query II > select * from test_filter_with_limit where value = 2 limit 1; > ---- > 2 2 > ``` Good suggestion! Thanks @korowa , i will address it soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
