goldmedal commented on code in PR #1551:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1551#discussion_r1886497777
##########
src/parser/mod.rs:
##########
@@ -1427,6 +1424,112 @@ impl<'a> Parser<'a> {
}
}
+ /// Try to parse an [Expr::CompoundFieldAccess] like `a.b.c` or `a.b[1].c`.
+ /// If all the fields are `Expr::Identifier`s, return an
[Expr::CompoundIdentifier] instead.
+ /// If only the root exists, return the root.
+ /// If self supports [Dialect::supports_partiql], it will fall back when
occurs [Token::LBracket] for JsonAccess parsing.
+ pub fn parse_compound_field_access(
+ &mut self,
+ root: Expr,
+ mut chain: Vec<AccessExpr>,
+ ) -> Result<Expr, ParserError> {
+ let mut ending_wildcard: Option<TokenWithSpan> = None;
+ let mut ending_lbracket = false;
+ while self.consume_token(&Token::Period) {
+ let next_token = self.next_token();
+ match next_token.token {
+ Token::Word(w) => {
+ let expr = Expr::Identifier(w.to_ident(next_token.span));
+ chain.push(AccessExpr::Dot(expr));
+ if self.consume_token(&Token::LBracket) {
+ if self.dialect.supports_partiql() {
+ ending_lbracket = true;
+ break;
+ } else {
+ self.parse_multi_dim_subscript(&mut chain)?
+ }
+ }
+ }
+ Token::Mul => {
+ // Postgres explicitly allows funcnm(tablenm.*) and the
+ // function array_agg traverses this control flow
+ if dialect_of!(self is PostgreSqlDialect) {
+ ending_wildcard = Some(next_token);
+ break;
+ } else {
+ return self.expected("an identifier after '.'",
next_token);
+ }
+ }
+ Token::SingleQuotedString(s) => {
+ let expr = Expr::Identifier(Ident::with_quote('\'', s));
+ chain.push(AccessExpr::Dot(expr));
+ }
+ _ => {
+ return self.expected("an identifier or a '*' after '.'",
next_token);
+ }
+ }
+ }
+
+ // if dialect supports partiql, we need to go back one Token::LBracket
for the JsonAccess parsing
+ if self.dialect.supports_partiql() && ending_lbracket {
+ self.prev_token();
+ }
+
+ if let Some(wildcard_token) = ending_wildcard {
+ let Some(id_parts) = Self::exprs_to_idents(&root, &chain) else {
+ return self.expected("an identifier or a '*' after '.'",
self.peek_token());
+ };
+ Ok(Expr::QualifiedWildcard(
+ ObjectName(id_parts),
+ AttachedToken(wildcard_token),
+ ))
+ } else if self.consume_token(&Token::LParen) {
+ let Some(id_parts) = Self::exprs_to_idents(&root, &chain) else {
+ return self.expected("an identifier or a '*' after '.'",
self.peek_token());
+ };
+ if dialect_of!(self is SnowflakeDialect | MsSqlDialect)
+ && self.consume_tokens(&[Token::Plus, Token::RParen])
+ {
+ Ok(Expr::OuterJoin(Box::new(
+ match <[Ident; 1]>::try_from(id_parts) {
+ Ok([ident]) => Expr::Identifier(ident),
+ Err(parts) => Expr::CompoundIdentifier(parts),
+ },
+ )))
Review Comment:
fixed by
[4b3818c](https://github.com/apache/datafusion-sqlparser-rs/pull/1551/commits/4b3818cfc10cc2a15b985e50a0579b932a9220f8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
