parthchandra commented on code in PR #1172:
URL: https://github.com/apache/datafusion-comet/pull/1172#discussion_r1887782670
##########
spark/src/main/scala/org/apache/spark/sql/comet/CometNativeScanExec.scala:
##########
@@ -71,6 +72,85 @@ case class CometNativeScanExec(
}
override def hashCode(): Int = Objects.hashCode(output)
+
+ override lazy val metrics: Map[String, SQLMetric] = {
+ CometMetricNode.baselineMetrics(sparkContext) ++
+ Map(
Review Comment:
Should we have some way of distinguishing between these metrics and those
from the current native scan? Perhaps the display string can have a short
prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
