Re: [PR] [minor] make recursive package dependency optional [datafusion]

[via GitHub]

findepi commented on code in PR #13778:
URL: https://github.com/apache/datafusion/pull/13778#discussion_r1888129000


##########
datafusion/common/Cargo.toml:
##########
@@ -61,7 +63,7 @@ object_store = { workspace = true, optional = true }
 parquet = { workspace = true, optional = true, default-features = true }
 paste = "1.0.15"
 pyo3 = { version = "0.22.0", optional = true }
-recursive = { workspace = true }
+recursive = { version = "0.1.1", optional = true }

Review Comment:
   also, define default `recursive-protection` feature and make it a default 
feature
   add `dep:recursive` to it



##########
datafusion/common/Cargo.toml:
##########
@@ -36,10 +36,12 @@ name = "datafusion_common"
 path = "src/lib.rs"
 
 [features]
+default = ["recursive-protection"]
 avro = ["apache-avro"]
 backtrace = []
 pyarrow = ["pyo3", "arrow/pyarrow", "parquet"]
 force_hash_collisions = []
+recursive-protection = ["recursive"]

Review Comment:
   ```suggestion
   recursive-protection = ["dep:recursive"]
   ```



##########
datafusion/expr/Cargo.toml:
##########
@@ -36,6 +36,8 @@ name = "datafusion_expr"
 path = "src/lib.rs"
 
 [features]
+default = ["recursive-protection"]
+recursive-protection = ["recursive"]

Review Comment:
   `dep:`



##########
datafusion/common/Cargo.toml:
##########
@@ -36,10 +36,12 @@ name = "datafusion_common"
 path = "src/lib.rs"
 
 [features]
+default = ["recursive-protection"]
 avro = ["apache-avro"]
 backtrace = []
 pyarrow = ["pyo3", "arrow/pyarrow", "parquet"]
 force_hash_collisions = []
+recursive-protection = ["recursive"]

Review Comment:
   see 
https://doc.rust-lang.org/cargo/reference/features.html#optional-dependencies
   
   
![image](https://github.com/user-attachments/assets/ddf52a65-d944-4a49-bfac-2ba6eeabf2db)
   



##########
datafusion/common/Cargo.toml:
##########
@@ -61,7 +63,7 @@ object_store = { workspace = true, optional = true }
 parquet = { workspace = true, optional = true, default-features = true }
 paste = "1.0.15"
 pyo3 = { version = "0.22.0", optional = true }
-recursive = { workspace = true }
+recursive = { version = "0.1.1", optional = true }

Review Comment:
   ```suggestion
   recursive = { workspace = true, optional = true }
   ```
   
   same in other places



##########
datafusion/expr/Cargo.toml:
##########
@@ -48,7 +50,7 @@ datafusion-functions-window-common = { workspace = true }
 datafusion-physical-expr-common = { workspace = true }
 indexmap = { workspace = true }
 paste = "^1.0"
-recursive = { workspace = true }
+recursive = { version = "0.1.1", optional = true }

Review Comment:
   use workspace version



##########
Cargo.toml:
##########
@@ -143,7 +143,6 @@ pbjson = { version = "0.7.0" }
 prost = "0.13.1"
 prost-derive = "0.13.1"
 rand = "0.8"
-recursive = "0.1.1"

Review Comment:
   revert, the version should still be defined here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org