Blizzara commented on PR #13803: URL: https://github.com/apache/datafusion/pull/13803#issuecomment-2548987977
> @Blizzara I would appreciate if you could take a look and let me know if this approach seems reasonable, or if I've [architecture astronauted](https://en.wikipedia.org/wiki/Architecture_astronaut) myself. Thanks for the ping - I took a look, and overall looks really good to me! I left couple thoughts (I see you already saw some), but nothing major. I already have usecase in mind for this internally, so looking forward to getting it merged 😄 One thing is we should consider splitting the consumer.rs into smaller files. It could be a separate PR to keep the diff smaller, but maybe moving all the static "consumer_X" functions into like `consumer/relations.rs`, `consumer/expressions.rs`, `consumer/literals.rs` and `consumer/types.rs` (and one more for utils etc) or similar? Feels like now could be a good moment to do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
