parthchandra commented on code in PR #1050:
URL: https://github.com/apache/datafusion-comet/pull/1050#discussion_r1889052482
##########
common/src/main/java/org/apache/comet/parquet/ColumnReader.java:
##########
@@ -172,28 +172,6 @@ public void close() {
/** Returns a decoded {@link CometDecodedVector Comet vector}. */
public CometDecodedVector loadVector() {
- // Only re-use Comet vector iff:
Review Comment:
Even though the conditions for reuse are extremely well documented here, it
is still confusing to keep track of memory while debugging. I seem to remember
that there was some gain from the memory reuse, but if more recent benchmarks
show no gain, should we remove this reuse (and simplify management of our
buffer lifetimes)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
