ramnivas commented on PR #1608: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1608#issuecomment-2549994506
An alternative design would be to add a new method in the `Dialect` trait with a default implementation and have `PostgreSqlDialect` override it. But, I see `dialect_of!(self is ...` usages , so I chose that. Let me know if I should implement that alternative. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
