Blizzara commented on code in PR #13803:
URL: https://github.com/apache/datafusion/pull/13803#discussion_r1890511596
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -21,23 +21,24 @@ use datafusion::arrow::array::{GenericListArray, MapArray};
use datafusion::arrow::datatypes::{
DataType, Field, FieldRef, Fields, IntervalUnit, Schema, TimeUnit,
};
-use datafusion::common::plan_err;
use datafusion::common::{
- not_impl_err, plan_datafusion_err, substrait_datafusion_err,
substrait_err, DFSchema,
- DFSchemaRef,
+ not_impl_datafusion_err, not_impl_err, plan_datafusion_err, plan_err,
+ substrait_datafusion_err, substrait_err, DFSchema, DFSchemaRef,
};
use datafusion::datasource::provider_as_source;
use datafusion::logical_expr::expr::{Exists, InSubquery, Sort};
use datafusion::logical_expr::{
- Aggregate, BinaryExpr, Case, EmptyRelation, Expr, ExprSchemable,
LogicalPlan,
- Operator, Projection, SortExpr, TryCast, Values,
+ Aggregate, BinaryExpr, Case, Cast, EmptyRelation, Expr, ExprSchemable,
Extension,
+ LogicalPlan, Operator, Projection, SortExpr, Subquery, TryCast, Values,
};
use substrait::proto::aggregate_rel::Grouping;
+use substrait::proto::expression as substrait_expression;
use substrait::proto::expression::subquery::set_predicate::PredicateOp;
use substrait::proto::expression_reference::ExprType;
use url::Url;
+use super::state::SubstraitPlanningState;
Review Comment:
Ah I see, yep I'd be for inlining it here, but not a critical thing then!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
